[PackageCMO] Workaround for static witness thunk linker issue.#74531
Merged
[PackageCMO] Workaround for static witness thunk linker issue.#74531
Conversation
Contributor
Author
|
@swift-ci smoke test |
PR #74468 rolled back conformance serialized kind to IsNotSerialized for non-public decls. This caused static witness thunks to be removed while use site expects them, causing linker issues. This PR provides a workaround until a proper fix is made. rdar://130103572
elsh
force-pushed
the
elsh/static-witness-linker-workaround
branch
from
09e40fd to
c94ba25
Compare
Contributor
Author
|
@swift-ci smoke test |
aschwaighofer
approved these changes
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #74468 rolled back conformance serialized kind to IsNotSerialized for non-public decls. This caused static witness thunks of package protocol to be removed while use site expects them, causing linker issues. This PR provides a workaround until a proper fix is made.
rdar://130103572